ci: fix docker-test.sh handling to fail on error #20847
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stelfrag
approved these changes
Aug 19, 2025
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Aug 19, 2025
(cherry picked from commit 68bef17)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Aug 22, 2025
(cherry picked from commit 68bef17)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The CI script did not exit with a non-zero code when
runtime-check.shfailed.Although the script was executed, the
ifbranch ended with a successful command (echo), so the overall job exited with 0 and masked the failure.Test Plan
Additional Information
For users: How does this change affect me?