Skip to content

Improve ACLK message parsing #20838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025
Merged

Conversation

stelfrag
Copy link
Collaborator

Summary
  • The incoming ACLK request type_id can only be http. No need to allocate/free type_id, check immediately and set has_type, is_http. This will avoid a malloc/free

@stelfrag stelfrag requested a review from thiagoftsm August 18, 2025 14:14
@stelfrag stelfrag marked this pull request as ready for review August 18, 2025 14:31
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Charts are shown as expected on cloud. LGTM!

@stelfrag stelfrag merged commit 00cb44c into netdata:master Aug 18, 2025
106 checks passed
@stelfrag stelfrag deleted the aclk_remove_type_id branch August 18, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants