chore(go.d/snmp): load & merge per-vendor SNMP metadata overrides #20837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the SNMP metadata overrides system from a single YAML file to a multi-file layout organized by vendor. The system now loads and merges all *.yaml/*.yml files from a metadata directory in alphabetical order, with later files taking precedence on conflicts.
- Replaced single file loading with directory-based scanning and merging
- Added comprehensive merge logic for enterprise numbers, system object IDs, and category/model overrides
- Updated path resolution logic to locate the new metadata directory structure
Reviewed Changes
Copilot reviewed 28 out of 34 changed files in this pull request and generated 27 comments.
| File | Description |
|---|---|
| src/go/plugin/go.d/pkg/snmputils/overrides.go | Core refactoring of loading logic to scan directory and merge multiple YAML files |
| src/go/plugin/go.d/pkg/snmputils/overrides_test.go | Added test to verify all metadata YAMLs load and merge correctly |
| src/go/plugin/go.d/config/go.d/snmp.profiles/metadata/*.yaml | New vendor-specific metadata files containing SNMP device overrides |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
stelfrag
previously approved these changes
Aug 18, 2025
stelfrag
approved these changes
Aug 18, 2025
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Aug 19, 2025
…tdata#20837) (cherry picked from commit 6f41125)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR switches SNMP metadata overrides from a single YAML to a multi-file layout (one file per vendor + an “other” file) and updates the loader to read and merge all
*.yaml|*.ymlfiles under the metadata directory.Split
meta_overrides.yamlinto vendor-scoped files (e.g.,cisco.yaml,juniper.yaml,hp.yaml, …) plusother.yaml.Test Plan
Additional Information
For users: How does this change affect me?