Skip to content

fix: child of NavigationEntry key generated in render (#813) #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2021
Merged

fix: child of NavigationEntry key generated in render (#813) #814

merged 1 commit into from
Mar 9, 2021

Conversation

delaneyb
Copy link
Contributor

@delaneyb delaneyb commented Mar 8, 2021

Fixes #813

@rigor789
Copy link
Member

rigor789 commented Mar 9, 2021

Nice catch!

@rigor789 rigor789 merged commit ee47fc1 into nativescript-vue:master Mar 9, 2021
@rigor789 rigor789 mentioned this pull request Mar 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rigor789 rigor789 rigor789 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NavigationEntry generates new key for child component on every re-render
2 participants
@delaneyb @rigor789