Skip to content

fix: include the tabview element #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2023
Merged

fix: include the tabview element #1064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 35 additions & 1 deletion src/nativescript/elements.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
import { Frame as NSCFrame, Page as NSCPage } from '@nativescript/core';
import {
Frame as NSCFrame,
Page as NSCPage,
TabView as NSCTabView,
TabViewItem as NSCTabViewItem,
} from '@nativescript/core';

import { warn } from '@vue/runtime-core';

Expand Down Expand Up @@ -217,4 +222,33 @@ export function registerCoreElements() {
},
},
);

registerElement(
'TabViewItem',
() => require('@nativescript/core').TabViewItem,
);

registerElement('TabView', () => require('@nativescript/core').TabView, {
model: {
prop: 'selectedIndex',
event: 'selectedIndexChange',
},
nodeOps: {
insert(child, parent) {
const tabView = parent.nativeView as NSCTabView;

if (child.nativeView instanceof NSCTabViewItem) {
const items = tabView.items || [];

parent.setAttribute('items', items.concat([child.nativeView]));
}
},
remove(child, parent) {
const tabView = parent.nativeView as NSCTabView;
const items = tabView.items.filter((item) => item !== child.nativeView);

parent.setAttribute('items', items);
},
},
});
}
2 changes: 1 addition & 1 deletion src/registry/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { NSVElement, NSVViewFlags } from '../dom';
import type { NSVElement, NSVViewFlags } from '../dom';

export type NSVElementResolver = () => any;

Expand Down