-
-
Notifications
You must be signed in to change notification settings - Fork 36k
Frustum: Support reversed depth in setFromProjectionMatrix()
#31464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
@Mugen87 FYI. |
Can't you just pass in the |
I don't think the renderer is accessible when the method is called... |
The light shadow classes could access the renderer if the shadow map module passes its reference to
AFAICS, with a bit of refactoring, it should be possible to just work with |
TBH, I'd appreciate it if this can be merged so we can get to the point where reverse depth is working correctly. There were so many bugs to address. I'll be glad to help with a refactoring once this settles down. Oh, remember, we still have to get reverse depth working for |
Sorry, my intent was not to block the PR. If we passing the reversed depth buffer boolean from I would wait with |
As the title says.