fix: improve error message for generic openid-client error MONGOSH-2487 #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to previous commits, this change ensures that diagnostic information is not lost through recent changes to openid-client's error system, where currently a number of errors are grouped together under "something went wrong" (https://github.com/panva/openid-client/blob/a1e4a4fd88fcdff12d88e3ff73f3e27fe5df4252/src/index.ts#L975) and the library expects consumers to consistently expose the `cause` property of the error object. This also unifies the two existing `messageFromError` and `errorString` implementations, which happened to duplicate each other.
kmruiz
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to previous commits, this change ensures that diagnostic information is not lost through recent changes to openid-client's error system, where currently a number of errors are grouped together under "something went wrong" (https://github.com/panva/openid-client/blob/a1e4a4fd88fcdff12d88e3ff73f3e27fe5df4252/src/index.ts#L975) and the library expects consumers to consistently expose the
causeproperty of the error object.This also unifies the two existing
messageFromErroranderrorStringimplementations, which happened to duplicate each other.