-
Notifications
You must be signed in to change notification settings - Fork 1
fix: always send a nonce in the auth request MONGOSH-1905 #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like there's a number of genuine CI failures:
|
(ah, duh, that's probably because of mongodb-js/devtools-shared#489) |
Those errors should be fixed once we update to the new mock oidc provider. The old one ignores the nonce completely, which now fails validation because we're expecting it in the token response. |
@nirinchev Do you want to consider making this an opt-in feature, as mentioned on Slack? |
Yeah, I'll try and investigate how that would look like. |
@nirinchev Fwiw, I think we can really make this an option that's parallel to In this case, I could see the case for passing the The alternative is to survey identity providers and confirm that all relevant ones support nonces – that the tests here pass means that at least Entra ID and Okta do, which is a great starting point. |
Needs mongodb-js/devtools-shared#489 for tests to pass.