CSHARP-5695: CSOT: Unified test spec runner #1758
Open
+56,087
−223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanych-sun
commented
Aug 18, 2025
|
|
||
| var stream = new NetworkStream(socket, true); | ||
|
|
||
| if (_settings.ReadTimeout.HasValue) |
There was a problem hiding this comment.
Read and Write timeout now is being applied by BinaryConnection.
sanych-sun
commented
Aug 18, 2025
| @@ -275,6 +281,10 @@ private void OpenHelper(OperationContext operationContext) | |||
|
|
|||
| helper.OpenedConnection(); | |||
| } | |||
| catch (OperationCanceledException) when (operationContext.IsTimedOut()) | |||
There was a problem hiding this comment.
OperationCanceledException could be thrown because of CombinedCancellationToken (see line 273), if we face it and operation context is timed out we should throw TimeoutExcpetion instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.