Compatibility with Node 12.0 - Upgrade to Gulp 4 #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mon-compte-github thanks a lot for the PR, will check this out! |
|
@mon-compte-github I'll merge the PR to the dev branch. Thanks a lot for the PR! I'll add some minor changes and make a new release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've started to work with you amazing html template months ago. I used it for an angular dashboard app. It's so easy to work with, I love it. Thank you very much for your work :-)
A few days ago, I had to fix stuff on my project but it didn't work anymore : my node installation had been updated to v12 and node-sass wasn't happy. So I decided to make my first pull request. Here it is ! Please be kind ;-)
I had to upgrade gulp to v4 so I corrected the building scripts, and add uglification to app and vendor js (should be optional but I dunno how to do it the right way with gulp).
Tell me if I made something wrong.
Best regards
Jay