Minor cleanups #414
Merged
Minor cleanups #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
refs/scalar/hidden/* was the old ref space for the FetchStep. The prefetch task in Git uses refs/prefetch/* Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
If we update GIT_OBJECT_DIRECTORY to a custom path and it doesn't match the Unix-style path in the config, git-gvfs-helper complains and fails! Make sure that we translate Windows-style paths to a Unix-style path. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
This is a throwback to the VFS for Git days where an unexpected exception somehow justified killing the GVFS.Mount process. Today, this only causes huge pain when trying to diagnose a unit test failure. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
The old link broke and we never noticed. The new process downloads a 'watchman.zip' file which expands to something like 'watchman\watchman-<tag>-windows\' and the *-expansion in CMD is strange. This requires some careful renaming of directories to place the results in a consistent place in order for the install script to work. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
mjcheetham
approved these changes
Aug 12, 2020
Scalar.Common/Git/GitProcess.cs
Outdated
|
|
||
| if (gitObjectsDirectory != null) | ||
| { | ||
| gitObjectsDirectory = gitObjectsDirectory.Replace(Path.DirectorySeparatorChar, '/'); |
There was a problem hiding this comment.
Is there not a helper method for this already?
There was a problem hiding this comment.
Yes, thanks! Paths.ConvertPathToGitFormat() and I found another place that can call it.
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These cleanups were discovered while working on #398:
log.excludeDecorationsince it will need multiple values.GIT_OBJECT_DIRECTORYinGitProcess.GitMaintenanceStep.