zephyr: Read erase block size from dts instead of using fixed value. #17861
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Galea <antonio.galea@gmail.com>
|
This is a nice improvement, but I found at least two boards that no longer build: Is it possible to only use this DT setting if it exists? |
Signed-off-by: Antonio Galea <antonio.galea@gmail.com>
I've added a check: if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On my Apollo3 board, which is supported by Zephyr, I can create a filesystem in flash but cannot get Micropython automount to work.
I've tracked the issue down to the fact that not all boards use the 4096 byte erase block size that MP is assuming in
vfs_init().My patch extracts the correct configuration value directly from the devicetree, so it should work out of the box for every Zephyr board (with a flash).
Testing
With my modification filesystem automount works correctly for my board, which needs 8192 as erase block size as specified in the devicetree configuration.
I've checked with a script, and AFAICT all Zephyr boards with a
zephyr,flashcompatible node have the required property explicitly defined in the devicetree.