Skip to content

DOC: Fix typo in axes docstring #30455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2025

Conversation

itsmeamitesh01
Copy link
Contributor

PR summary

PR checklist

@rcomer
Copy link
Member

rcomer commented Aug 22, 2025

That is not the xlabel docstring.

Since there are four of them, I'm not sure floats was necessarily a typo. A quick search shows that we do both "tuple of [plural]" and "tuple of [singular]" in various places so we have not standardised.

@timhoffm
Copy link
Member

I don't think it really matters as both variants are equally understandable. If we want to standardize, I'd slightly favor "tuple of float" in analogy to "tuple of str".

@itsmeamitesh01
Copy link
Contributor Author

Thank you both for the feedback and the clarification!

It sounds like this is more of a style preference with no established standard yet. Since I'm new to contributing, I'm happy to follow your lead.

If the consensus is to leave the original wording as is, I am perfectly happy to close this pull request. No problem at all.

Thanks again for your time!

Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with @timhoffm's semi-approval.

@QuLogic QuLogic merged commit 1ddb1ec into matplotlib:main Aug 23, 2025
48 of 49 checks passed
@github-project-automation github-project-automation bot moved this from Needs decision to Waiting for author in First Time Contributors Aug 23, 2025
@QuLogic
Copy link
Member

QuLogic commented Aug 23, 2025

Ah sorry, I should've renamed this before merging.

@QuLogic QuLogic changed the title DOC: Fix typo in xlabel docstring DOC: Fix typo in axes docstring Aug 23, 2025
@QuLogic QuLogic added this to the v3.11.0 milestone Aug 23, 2025
@itsmeamitesh01
Copy link
Contributor Author

That's fantastic! Thank you so much for the review and for merging it.

@itsmeamitesh01 itsmeamitesh01 deleted the docs-fix-xlabel-typo branch August 23, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for author
Development

Successfully merging this pull request may close these issues.

4 participants