Replace FT2Image by plain numpy arrays. #30044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failures look related and real, but I have no good guess as to why not on osx. |
fc3e947 to
c69331b
Compare
|
I forgot to zero-initialize the FT2Image. Fixed. |
QuLogic
approved these changes
May 16, 2025
|
If we end up doing #30059, does that mean this PR is also not necessary (other than applying a deprecation, probably)? |
|
Indeed, but I didn't remove this PR as 1) the deprecation will still be needed anyways, and 2) it's a much simpler PR, which can hopefully get in faster if #30059 gets stalled. |
timhoffm
reviewed
May 17, 2025
timhoffm
reviewed
May 18, 2025
timhoffm
approved these changes
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FT2Image predates numpy, but we don't really need to maintain our own 2D buffer class nowadays.
PR summary
PR checklist