Skip to content

MultiNorm class #29876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Aug 20, 2025
Merged

MultiNorm class #29876

merged 19 commits into from
Aug 20, 2025
+536 −0

Conversation

trygvrad
Copy link
Contributor

@trygvrad trygvrad commented Apr 6, 2025

PR summary

This PR continues the work of #28658 and #28454, aiming to close #14168. (Feature request: Bivariate colormapping)

This is part one of the former PR, #29221. Please see #29221 for the previous discussion

Features included in this PR:

  • A MultiNorm class. This is a subclass of colors.Normalize and holds n_variate norms.
  • Testing of the MultiNorm class

Features not included in this PR:

  • changes to colorizer.py needed to expose the MultiNorm class
  • Exposes the functionality provided by MultiNorm together with BivarColormap and MultivarColormap to the plotting functions axes.imshow(...), axes.pcolor, and `axes.pcolormesh(...)
  • Testing of the new plotting methods
  • Examples in the docs

This was referenced Apr 6, 2025
Open
Open
oscargus
oscargus reviewed Apr 6, 2025
View reviewed changes
oscargus
oscargus reviewed Apr 6, 2025
View reviewed changes
oscargus
oscargus reviewed Apr 6, 2025
View reviewed changes
anntzer
anntzer reviewed Apr 7, 2025
View reviewed changes
anntzer
anntzer reviewed Apr 7, 2025
View reviewed changes
anntzer
anntzer reviewed Apr 7, 2025
View reviewed changes
QuLogic
QuLogic reviewed Apr 17, 2025
View reviewed changes
@trygvrad trygvrad force-pushed the multivariate-plot-prapare branch from 55b85e3 to f42d65b Compare April 17, 2025 15:18
anntzer
anntzer reviewed May 1, 2025
View reviewed changes
anntzer
anntzer reviewed May 1, 2025
View reviewed changes
anntzer
anntzer reviewed May 1, 2025
View reviewed changes
anntzer
anntzer reviewed May 1, 2025
View reviewed changes
anntzer
anntzer reviewed May 1, 2025
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor points, plus re-pinging @timhoffm in case he has an opinion re: n_input / input_dims naming?

@trygvrad
Copy link
Contributor Author

trygvrad commented May 4, 2025

Thank you for the feedback @anntzer !
Hopefully we can hear if @timhoffm has any thoughts on n_input / input_dims naming within the coming week.

@timhoffm
Copy link
Member

timhoffm commented May 5, 2025

See #29876 (comment)

@trygvrad
Copy link
Contributor Author

trygvrad commented May 7, 2025

Thank you @timhoffm
The PR should now be as we agreed (#29876 (comment)) :)

QuLogic
QuLogic reviewed May 23, 2025
View reviewed changes
@trygvrad
Copy link
Contributor Author

trygvrad commented Jun 1, 2025

@QuLogic Thank you again and apologies for my tardiness (I was sick)
@timhoffm Do you think you could approve this PR now?

timhoffm
timhoffm reviewed Jun 2, 2025
View reviewed changes
QuLogic
QuLogic reviewed Jun 4, 2025
View reviewed changes
@trygvrad trygvrad force-pushed the multivariate-plot-prapare branch from 6b86d63 to 32247f5 Compare June 4, 2025 21:01
@trygvrad trygvrad mentioned this pull request Jun 6, 2025
Closed
@trygvrad
Copy link
Contributor Author

trygvrad commented Jun 6, 2025

This is on hold until we sort out #30149 (Norm Protocol)
see #29876 (comment)

@trygvrad trygvrad mentioned this pull request Jun 15, 2025
Merged
trygvrad and others added 3 commits August 1, 2025 12:54
@trygvrad
Copy link
Contributor Author

trygvrad commented Aug 1, 2025

I changed vmin, vmax and clip to only accept iterables or None.

It dawned on me that it will be useful to allow None, with the behavior that it does not modify the vmin/vmax/clip on the constituent norms. This will be useful for use as a default, but also be useful for users that want to combine multiple norms into a MultiNorm without modifying the limits of the norms.

@timhoffm @anntzer I had made these changes, but actually committing them had slipped my mind. They are in now 😅

I'm on vacation now, so my schedule is a bit scrambled. @QuLogic I'll take a look at the rest of your comments soon :)

timhoffm
timhoffm reviewed Aug 1, 2025
View reviewed changes
@anntzer
Copy link
Contributor

anntzer commented Aug 1, 2025

@timhoffm @anntzer I had made these changes, but actually committing them had slipped my mind. They are in now 😅

I'm on vacation now, so my schedule is a bit scrambled. @QuLogic I'll take a look at the rest of your comments soon :)

Sorry I dropped the ball on this. I can try to have a look but not before the middle of the month or so.

QuLogic
QuLogic reviewed Aug 7, 2025
View reviewed changes
@trygvrad @QuLogic
Apply suggestions from code review
f61c06b 
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@trygvrad trygvrad force-pushed the multivariate-plot-prapare branch from ff2eb20 to f61c06b Compare August 7, 2025 21:25
@trygvrad
Copy link
Contributor Author

@QuLogic all the comments should have been addressed now, do you have the time to take another pass at it?

@QuLogic
Copy link
Member

QuLogic commented Aug 15, 2025

@QuLogic all the comments should have been addressed now, do you have the time to take another pass at it?

There are still a couple of comments that are unresolved/have no reply, at least.

@trygvrad
Copy link
Contributor Author

@QuLogic @story645 thank you for your comments and patience on this, I believe i have addressed all the comments now, but please correct me again if there are some I have overlooked. Otherwise I look forward to your future comments :)

QuLogic
QuLogic reviewed Aug 16, 2025
View reviewed changes
QuLogic
QuLogic reviewed Aug 16, 2025
View reviewed changes
@trygvrad @QuLogic
Apply suggestions from code review
3267fe9 
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@trygvrad trygvrad force-pushed the multivariate-plot-prapare branch from 486a58f to 3267fe9 Compare August 16, 2025 20:42
@QuLogic QuLogic added this to the v3.11.0 milestone Aug 19, 2025
QuLogic
QuLogic reviewed Aug 20, 2025
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor last thing,

@trygvrad
Copy link
Contributor Author

Just a minor last thing,

Thank you @QuLogic !

QuLogic
QuLogic approved these changes Aug 20, 2025
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you expecting a squash merge?

@trygvrad
Copy link
Contributor Author

Were you expecting a squash merge?

Yes, I believe a squash merge would be most suitable

@QuLogic QuLogic merged commit 3a8ad1d into matplotlib:main Aug 20, 2025
38 of 40 checks passed
@QuLogic
Copy link
Member

QuLogic commented Aug 20, 2025

Thanks for working your way through this long process.

@Migelo Migelo mentioned this pull request Aug 21, 2025
Merged
This was referenced Aug 25, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@story645 story645 story645 left review comments

@anntzer anntzer anntzer left review comments

@jklymak jklymak jklymak left review comments

@timhoffm timhoffm timhoffm approved these changes

@oscargus oscargus oscargus left review comments

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Documentation: API files in lib/ and doc/api topic: color/color & colormaps
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.

Feature request: Bivariate colormapping
7 participants
@trygvrad @timhoffm @anntzer @QuLogic @story645 @jklymak @oscargus