Skip to content

TST: pin flake8 #29834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2025
Merged

TST: pin flake8 #29834

merged 2 commits into from
Mar 30, 2025

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Mar 29, 2025

Flake8 7.2.0 doesn't like

matplotlib/lib/matplotlib/_mathtext.py

Lines 1612 to 1624 in 2933275

def hlist_out(box: Hlist) -> None:
nonlocal cur_v, cur_h, off_h, off_v
cur_g = 0
cur_glue = 0.
glue_order = box.glue_order
glue_sign = box.glue_sign
base_line = cur_v
left_edge = cur_h
for p in box.children:
if isinstance(p, Char):
p.render(output, cur_h + off_h, cur_v + off_v)

But that code passed before. Seems like maybe a bug on their end? But I'm not familiar with nonlocal to be honest.

This PR just pins flake8 to unbreak CI

rcomer
rcomer approved these changes Mar 30, 2025
View reviewed changes
Copy link
Member

@rcomer rcomer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't hurt, particularly as there is talk of moving to ruff.

@rcomer rcomer merged commit cf948de into matplotlib:main Mar 30, 2025
38 of 41 checks passed
@rcomer rcomer mentioned this pull request Mar 30, 2025
Merged
5 tasks
@QuLogic QuLogic modified the milestones: v3.11.0, v3.10-doc Mar 31, 2025
@QuLogic
Copy link
Member

QuLogic commented Apr 5, 2025

@meeseeksdev backport to v3.10.x
@meeseeksdev backport to v3.10.1-doc

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 5, 2025
@jklymak @meeseeksmachine
Backport PR matplotlib#29834: TST: pin flake8
479ed1e
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 5, 2025
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 5, 2025
@jklymak @meeseeksmachine
Backport PR matplotlib#29834: TST: pin flake8
f66a9cb
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 5, 2025
Merged
QuLogic added a commit that referenced this pull request Apr 5, 2025
@QuLogic
Merge pull request #29868 from meeseeksmachine/auto-backport-of-pr-29…
4bf746b 
…834-on-v3.10.x

Backport PR #29834 on branch v3.10.x (TST: pin flake8)
@QuLogic QuLogic added the CI: testing CI configuration and testing label Apr 5, 2025
QuLogic added a commit that referenced this pull request Apr 5, 2025
@QuLogic
Merge pull request #29869 from meeseeksmachine/auto-backport-of-pr-29…
f372e6d 
…834-on-v3.10.1-doc

Backport PR #29834 on branch v3.10.1-doc (TST: pin flake8)
@ksunden ksunden mentioned this pull request May 9, 2025
Closed
5 tasks
@ksunden ksunden mentioned this pull request Jul 25, 2025
Merged
5 tasks
@ksunden ksunden mentioned this pull request Aug 7, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcomer rcomer rcomer approved these changes

Assignees
No one assigned
Labels
CI: testing CI configuration and testing
Projects
None yet
Milestone
v3.10-doc
Development

Successfully merging this pull request may close these issues.
3 participants
@jklymak @QuLogic @rcomer