Fix escaping of nulls and "0" in default filenames. #29781
Merged
+13
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Mar 19, 2025
lib/matplotlib/backend_bases.py
Outdated
| @@ -2220,7 +2220,7 @@ def get_default_filename(self): | |||
| # Characters to be avoided in a NT path: | |||
| # https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx#naming_conventions | |||
| # plus ' ' | |||
| removed_chars = r'<>:"/\|?*\0 ' | |||
| removed_chars = r'<>:"/\|?*''\0 ' | |||
There was a problem hiding this comment.
I find this a bit too clever. This seems simpler
Suggested change
| removed_chars = r'<>:"/\|?*''\0 ' | |
| removed_chars = '<>:"/\\|?*\0 ' |
Adding a test for this required tweaking a bit the behavior of non-GUI managers (so that they also store the window title); note that the comment of non-GUIs returning None was clearly wrong.
dstansby
approved these changes
Mar 20, 2025
timhoffm
approved these changes
Mar 20, 2025
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 20, 2025
QuLogic
added a commit
that referenced
this pull request
Mar 20, 2025
…781-on-v3.10.x Backport PR #29781 on branch v3.10.x (Fix escaping of nulls and "0" in default filenames.)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a test for this required tweaking a bit the behavior of non-GUI managers (so that they also store the window title); note that the comment of non-GUIs returning None was clearly wrong.
Closes #29779.
PR summary
PR checklist