Skip to content

Add test_fill in test_datetime.py #27401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 2, 2023
Merged

Add test_fill in test_datetime.py #27401

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40e8132
added a test for fill in test_datetime.py
nidaa-7 Nov 29, 2023
7de0d46
Removed saving the picture from test code.
nidaa-7 Nov 30, 2023
6157b1f
reverted .gitignore changes
nidaa-7 Nov 30, 2023
b553dab
added seed
nidaa-7 Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions lib/matplotlib/tests/test_datetime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,11 +266,32 @@ def test_eventplot(self):
fig, ax = plt.subplots()
ax.eventplot(...)

@pytest.mark.xfail(reason="Test for fill not written yet")
@mpl.style.context("default")
def test_fill(self):
fig, ax = plt.subplots()
ax.fill(...)
mpl.rcParams["date.converter"] = "concise"
fig, (ax1, ax2, ax3, ax4) = plt.subplots(4, 1, layout="constrained")

np.random.seed(19680801)

x_base_date = datetime.datetime(2023, 1, 1)
x_dates = [x_base_date]
for _ in range(1, 5):
x_base_date += datetime.timedelta(days=np.random.randint(1, 5))
x_dates.append(x_base_date)

y_base_date = datetime.datetime(2023, 1, 1)
y_dates = [y_base_date]
for _ in range(1, 5):
y_base_date += datetime.timedelta(days=np.random.randint(1, 5))
y_dates.append(y_base_date)

x_values = np.random.rand(5) * 5
y_values = np.random.rand(5) * 5 - 2

ax1.fill(x_dates, y_values)
ax2.fill(x_values, y_dates)
ax3.fill(x_values, y_values)
ax4.fill(x_dates, y_dates)

@pytest.mark.xfail(reason="Test for fill_between not written yet")
@mpl.style.context("default")
Expand Down