Skip to content

DOC: made "open PR on MPL" a section in contribute guide #26961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2023
Merged

DOC: made "open PR on MPL" a section in contribute guide #26961

merged 2 commits into from
Oct 6, 2023

Conversation

story645
Copy link
Member

PR summary

  • pulled out "how to send PR to Matplotlib" into its own section and fleshed it out a drop b/c I felt like it was getting a little lost.
  • added a workflow overview section title to generate an anchor on the rhs
  • changed title underlines to documented standard

PR checklist

@story645 story645 added the Documentation: devdocs files in doc/devel label Sep 29, 2023
@story645 story645 requested a review from melissawm September 29, 2023 15:13
QuLogic
QuLogic reviewed Sep 30, 2023
View reviewed changes
timhoffm
timhoffm reviewed Sep 30, 2023
View reviewed changes
story645 and others added 2 commits October 1, 2023 23:51
@story645 @QuLogic
turned send to matplotlib into a section and added some more info so …
8f52c28 
…it would stand out

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@story645
changed title level to documented leveling format
754ec45
melissawm
melissawm approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1!

@story645 story645 mentioned this pull request Oct 3, 2023
Closed
16 tasks
@story645
Copy link
Member Author

story645 commented Oct 6, 2023

Made the changes on this one.

@ksunden ksunden added this to the v3.8-doc milestone Oct 6, 2023
@ksunden ksunden merged commit a99673c into matplotlib:main Oct 6, 2023
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 6, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 6, 2023
@ksunden @meeseeksmachine
Backport PR matplotlib#26961: DOC: made "open PR on MPL" a section in…
77cdc52 
… contribute guide
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 6, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 6, 2023
@ksunden @meeseeksmachine
Backport PR matplotlib#26961: DOC: made "open PR on MPL" a section in…
0b05c39 
… contribute guide
@story645 story645 deleted the contribute_guide branch October 6, 2023 16:11
rcomer added a commit that referenced this pull request Oct 6, 2023
@rcomer
Merge pull request #27019 from meeseeksmachine/auto-backport-of-pr-26…
81147a2 
…961-on-v3.8.0-doc

Backport PR #26961 on branch v3.8.0-doc (DOC: made "open PR on MPL" a section in contribute guide)
rcomer added a commit that referenced this pull request Oct 6, 2023
@rcomer
Merge pull request #27018 from meeseeksmachine/auto-backport-of-pr-26…
de99097 
…961-on-v3.8.x

Backport PR #26961 on branch v3.8.x (DOC: made "open PR on MPL" a section in contribute guide)
@ksunden ksunden mentioned this pull request Nov 2, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

@timhoffm timhoffm timhoffm left review comments

@ksunden ksunden ksunden approved these changes

+1 more reviewer

@melissawm melissawm melissawm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Documentation: devdocs files in doc/devel
Projects
None yet
Milestone
v3.8-doc
Development

Successfully merging this pull request may close these issues.
5 participants
@story645 @QuLogic @ksunden @timhoffm @melissawm