Skip to content

Conversation

ksunden
Copy link
Member

@ksunden ksunden commented Sep 26, 2023

PR summary

Mark the expected interface for some things such as Transform.input_dims as read-only via a property and remove redundant versions in subclasses

Same for some offsetbox code

Fix rcsetup ignores

PR checklist

@@ -149,15 +137,12 @@ matplotlib.axes._base._AxesBase.get_fc
matplotlib.axes._base._AxesBase.set_fc

# Other dynamic python behaviors not type hinted
matplotlib.rcsetup.defaultParams
#matplotlib.rcsetup.defaultParams
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

Mark the expected interface for some things such as Transform.input_dims as read-only via a property and remove redundant versions in subclasses

Same for some offsetbox code

Fix rcsetup ignores
@oscargus oscargus added this to the v3.8.1 milestone Sep 28, 2023
@oscargus oscargus merged commit c333052 into matplotlib:main Sep 28, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 28, 2023
oscargus added a commit that referenced this pull request Sep 28, 2023
…927-on-v3.8.x

Backport PR #26927 on branch v3.8.x ([TYP] Remove some stubtest allowlist entries)
@ksunden ksunden mentioned this pull request Nov 2, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants