Skip to content

Fix Deprecation in patches.py #26875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Fix Deprecation in patches.py #26875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a29c2fa
Removed deprecated API
gaurichaudhari9 Sep 22, 2023
c3e06ed
Removed deprecated stub
gaurichaudhari9 Sep 22, 2023
a31970f
Create GC.rst
gaurichaudhari9 Sep 22, 2023
c4e3310
Rename GC.rst to 26874-GC.rst
gaurichaudhari9 Sep 22, 2023
9d2859e
Rename 26874-GC.rst to 26875-GC.rst
gaurichaudhari9 Sep 22, 2023
4a3004c
Fixed Blank lines
gaurichaudhari9 Sep 22, 2023
9f4f9aa
Fixed blank lines
gaurichaudhari9 Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/api/next_api_changes/removals/26875-GC.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
class SimpleEvent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be explicit about the path to the class:

Suggested change
class SimpleEvent
``matplotlib.patches.ConnectionStyle._Base.SimpleEvent``
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


... is removed without replacements.
6 changes: 0 additions & 6 deletions lib/matplotlib/patches.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2707,12 +2707,6 @@ class _Base:
points. This base class defines a __call__ method, and a few
helper methods.
"""

@_api.deprecated("3.7")
class SimpleEvent:
def __init__(self, xy):
self.x, self.y = xy

def _in_patch(self, patch):
"""
Return a predicate function testing whether a point *xy* is
Expand Down
3 changes: 0 additions & 3 deletions lib/matplotlib/patches.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,9 +455,6 @@ class BoxStyle(_Style):

class ConnectionStyle(_Style):
class _Base(ConnectionStyle):
class SimpleEvent:
def __init__(self, xy: tuple[float, float]) -> None: ...

def __call__(
self,
posA: tuple[float, float],
Expand Down