Pin NumPy below v2 for 3.7.x #26706
Merged
Pin NumPy below v2 for 3.7.x #26706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
approved these changes
Sep 6, 2023
timhoffm
approved these changes
Sep 6, 2023
|
Failed test is a subprocess timeout and unrelated to numpy pinning. Note that this is not a full protection against getting broken environments because earlier matplotlib versions are unpinnend, and the solver may choose to downgrade to matplotlib 3.7.2 to be able to use numpy=2. Anyway, pinning now is better than not doing anything. |
This was referenced Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Pre-emptively pinning away from the major API break for the last bugfix release of the 3.7.x series.
PR checklist