Skip to content

Conversation

story645
Copy link
Member

  • got rid of the optional for pre-commit hooks b/c honestly I think it's a better use of contributors time, and therefore a better experience, to just learn how to use 'em than to go back and forth w/ reviewers.
  • Because I want to get rid of the optional, I fleshed out the purpose of pre-commit hooks- what they're for, why they're useful.
  • in fleshing out pre-commits, added a but more explanation to the editing workflow.
  • second commit: got rid of the overview section in editing workflow b/c I don't know who it's for - folks who know how to use git don't need it, and folks who don't know how to use git should really read the whole section.

@story645 story645 added the Documentation: devdocs files in doc/devel label Aug 22, 2023
Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@QuLogic QuLogic added this to the v3.8.0 milestone Aug 23, 2023
@QuLogic QuLogic merged commit a4dca24 into matplotlib:main Aug 23, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 23, 2023
QuLogic added a commit that referenced this pull request Aug 23, 2023
…572-on-v3.8.x

Backport PR #26572 on branch v3.8.x ([DOC]: clarify pre-commits and editing workflow)
@story645 story645 deleted the pre-commit branch August 23, 2023 16:47
@ksunden ksunden mentioned this pull request Sep 15, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: devdocs files in doc/devel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants