Allow separate config of minor grid params in matplotlibrc. #26121
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Is there interest in this? |
|
It seems ok but is a breaking change for any style that customized the grid style and expected the minor grid to change as well? |
|
Yes, the |
|
cc @timhoffm on that. |
Agreed, I can update to ignore the .minor.* param unless explicitly set. |
|
I think the pragmatic approach here is do use "inherit" as a default value and if that is encountered, use the respective non-minor grid value. This also rhymes with the layering hierarchy that (major) is under A revised config framework may add reusing other values within the config classes as well, but for now, the pragmatic solution is to hard-code that inheritance at the usage sites of |
PR summary
Adds
grid.minor.*params tomatplotlibrcallowing one to set different parameters for minor grids. I've been manually turning on minor ticks with.grid(which="minor"), but this gets tiring and I'd like to be able to just enable this globally in thematplotlibrcfile. However, both themajorandminorparameters are currently configured withgrid.*, with no distinction forminorormajor. The present PR attempts to address this.I can add examples / test / docs etc. if this might be an acceptable change.
PR checklist