Fix for antl4 import error in Python>=3.12 - #21
Open
Esat-Karakaya wants to merge 2 commits into
Open
Conversation
Added compatibility shim to use antlr4 for python>=3.12
Author
|
this PR is a fix for this issue: #17 (Python son sürümde çalışmıyor) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Antlr4 imports typing.io to use TextIO which already exists in the typing module. typing.io was removed in python 3.12 and this caused zemberek-python to not work on modern python runtimes. This pull request allows zemberek-python to import antlr4 in modern python without issues.
It also fixes a small bug where 0012 would not be converted to "sıfır sıfır on iki"