fix(Button): Change button to outlined #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in the light theme the "contained" buttons appear white on white, which makes them invisible to the eye. This is already strange as I'm using the native theme / style suggested from the docs. Turns out you can update the @docker npm packages to newer version which should fix this issue, but they cause some overhead issues with them
I also tried to re-create a new extension from scratch to see what was needed to be updated to make it work properly but apparently the command to create a new extension is broken (see docker/extensions-sdk#304 )
As a simple and effective solution, I decided to just change the buttons to be outlined which solves the issue, even though I like it less from a UI prospective 🙃
(There is some formatting that can be ignored, the only changes are adding
variant="outlined"
to some buttons and changing some "contained" to "outlined")Closes #55