Skip to content

fix(Button): Change button to outlined #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

fix(Button): Change button to outlined #58

merged 1 commit into from
Jun 25, 2025

Conversation

Pive01
Copy link
Collaborator

@Pive01 Pive01 commented Jun 24, 2025

Currently in the light theme the "contained" buttons appear white on white, which makes them invisible to the eye. This is already strange as I'm using the native theme / style suggested from the docs. Turns out you can update the @docker npm packages to newer version which should fix this issue, but they cause some overhead issues with them

Failed to compile.

Module parse failed: 'import' and 'export' may appear only with 'sourceType: module' (1:0)
File was processed with these loaders:
 * ./node_modules/babel-loader/lib/index.js
 * ./node_modules/source-map-loader/dist/cjs.js
You may need an additional loader to handle the result of these loaders.
> import React, { useMemo } from 'react';
| import { createTheme, ThemeProvider, useMediaQuery } from '@mui/material';
| /** @deprecated Use either DockerMuiV5ThemeProvider or DockerMuiV6ThemeProvider */
ERROR in ./node_modules/@docker/docker-mui-theme/dist/index.js 1:0
Module parse failed: 'import' and 'export' may appear only with 'sourceType: module' (1:0)
File was processed with these loaders:
 * ./node_modules/babel-loader/lib/index.js
 * ./node_modules/source-map-loader/dist/cjs.js
You may need an additional loader to handle the result of these loaders.
> import React, { useMemo } from 'react';
| import { createTheme, ThemeProvider, useMediaQuery } from '@mui/material';
| /** @deprecated Use either DockerMuiV5ThemeProvider or DockerMuiV6ThemeProvider */

webpack compiled with 1 error
No issues found.

I also tried to re-create a new extension from scratch to see what was needed to be updated to make it work properly but apparently the command to create a new extension is broken (see docker/extensions-sdk#304 )

As a simple and effective solution, I decided to just change the buttons to be outlined which solves the issue, even though I like it less from a UI prospective 🙃

(There is some formatting that can be ignored, the only changes are adding variant="outlined" to some buttons and changing some "contained" to "outlined")

Closes #55

@Pive01 Pive01 requested a review from lukqw June 24, 2025 11:21
@Pive01 Pive01 merged commit c9c91f3 into main Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't run version 0.5.3 of the extension on MacOS Sequoia 15.5
2 participants