SNS: support passing MessageGroupId to non-FIFO topic
#13019
Merged
+206
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
007ecdb to
227c351
Compare
Test Results - Preflight, Unit22 139 tests 20 404 ✅ 6m 27s ⏱️ Results for commit 8a98ce0. ♻️ This comment has been updated with latest results. |
Test Results (amd64) - Acceptance7 tests 5 ✅ 3m 10s ⏱️ Results for commit 8a98ce0. ♻️ This comment has been updated with latest results. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 1h 31m 18s ⏱️ Results for commit 8a98ce0. ♻️ This comment has been updated with latest results. |
LocalStack Community integration with Pro 2 files 2 suites 1h 3m 6s ⏱️ Results for commit 8a98ce0. ♻️ This comment has been updated with latest results. |
thrau
approved these changes
Aug 18, 2025
Comment on lines
+774
to
+778
| standard_message = SqsMessage( | ||
| time.time(), | ||
| message, | ||
| message_group_id=message_group_id, | ||
| ) |
There was a problem hiding this comment.
thanks for catching and fixing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Related to #13008 -> https://aws.amazon.com/about-aws/whats-new/2025/07/amazon-sns-standard-topics-sqs-fair-queues/
Since adding support for SQS Fair Queues, we can now pass a
MessageGroupIdto non-FIFO topic.This PR implements that behavior in SNS, removing the previously raised exception, and properly passing the attribute.
This also fixes the behavior in SQS itself following #12930, because we were not adding the
MessageGroupIdto theAttributesof the received Message, as this only done for FIFO queue. I've updated the SQS test to verify thisChanges
SQS.SendMessageMessageGroupIdasAttributesof the message