Skip to content

[12.x] Improve collection return types #56599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2025
Merged

[12.x] Improve collection return types #56599

merged 1 commit into from
Aug 10, 2025

Conversation

axlon
Copy link
Contributor

@axlon axlon commented Aug 9, 2025 •
edited
Loading

This PR allows static analysis tools to better understand what Collection::pop(), Collection::shift(), and Collection::random() return based on the passed parameters

@axlon axlon force-pushed the collection-pop-random branch from 40b1c08 to c774688 Compare August 9, 2025 13:51
@taylorotwell taylorotwell merged commit 7d87cde into laravel:12.x Aug 10, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axlon @taylorotwell