Skip to content

[12.x] use clearer pagination view names #56297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

browner12
Copy link
Contributor

it's been a LONG time since Bootstrap 3 was the default pagination view, but it looks like their file names persisted. we'll update the view file names to explicitly describe them as the Bootstrap 3 views.

this will help avoid confusion since Tailwind is our default now.

it's been a LONG time since Bootstrap 3 was the default pagination view, but it looks like their file names persisted. we'll update the view file names to explicitly describe them as the Bootstrap 3 views.

this will help avoid confusion since Tailwind is our default now.
@rodrigopedra
Copy link
Contributor

Wouldn't this be a breaking change for anyone who exported the views to customize them?

php artisan vendor:publish --tag=laravel-pagination

@browner12
Copy link
Contributor Author

browner12 commented Jul 15, 2025

yah, originally I was gonna send to master, but then I thought I'd give it a shot here to see what people thought. can re-submit if needed.

very curious if anyone's still using BS3 🤣

@rodrigopedra
Copy link
Contributor

Many projects only keep the backend up to date. Especially in-company ones, such as business dashboards.

The other day I helped a friend in a project that was upgraded to Laravel 12 but kept using AngularJS (the first one) on their frontend.

Also, one could have exported those views in the past and customized them manually while migrating to another CSS framework or to a bespoke CSS.

I'd be on the safe side and document this change on a major version.

@taylorotwell
Copy link
Member

Probably can't do the breaking change on a patch release.

@browner12
Copy link
Contributor Author

thanks, i'll send to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants