Fix wrong seek with Gstreamer #9159
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not valid active window (ex: active window is None), _density will be 0.
|
@kuzeyron anything is blocking this PR? |
|
Unit tests for MacOS and Windows are failing? |
I have to test these changes locally before I make any statements. |
If you look at the PR, I have only changes a few lines. Gstreamer is windows provider only, I don't know why the unitests is failing on OSX. Also, I have check the unitests for windows, I don't understand the message. Maybe someone can help on this, 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix issue with Gstreamer only #6292.
As mentioned in this issue, to be precise with the seek function we need to use flags ACCURATE instead of KEY_UNIT.
I test it for one of by project and it work like charm.
Below are items maintainers should consider when merging the PR. Feel free to suggest a
unit@label or check-mark the others as appropriate.-->
Maintainer merge checklist
Component: xxxlabel.api-deprecationorapi-breaklabel.release-highlightlabel to be highlighted in release notes.versionadded,versionchangedas needed.