feat: refactor views to use DRF status codes, consistent responses, a… #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd serializer validation Signed-off-by: AyushmanPanigrahi <ayushmanayp@gmail.com>
|
Hey @alloy77, Thank you for raising the pr. Our team will review the changes soon. |
There was a problem hiding this comment.
Great refactor! Here are a few suggestions to further improve the code:
You’ve switched to using DRF’s Response and appropriate status codes, which is excellent. However, consider returning more informative error messages for validation errors (in POST/PUT) rather than just the serializer errors, especially if they could be nested or unclear to API consumers.
|
Overall good pr @alloy77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nd serializer validation
This pull request refactors the application’s views to:
ResponseobjectsThese changes enhance code readability, maintainability, and API reliability.