Refactor SMS sender app to use async httpx and improved validation #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for raising the pr, Our team will review the pr soon before that please make sure to sign the DCO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the SMS sender FastAPI app for improved performance, validation, and error handling. Key changes:
An overal summary
requeststo asynchronoushttpx.AsyncClientpydantic.Fieldlifespan()for modern startup/shutdown handlingJSONResponserequirements.txtChanges i made
✅ Replaced
requests.postwithhttpx.AsyncClient✅ Updated endpoint to
async def✅ Added phone number pattern validation (
+91...etc.)✅ Introduced
lifespan()for lifecycle management✅ Added proper error responses with status codes
✅ Updated logging for Twilio and HTTP errors
✅ Created
requirements.txtwith minimal necessary deps