Enhance Student API: Fix Security Issues, Add Input Validation & Error Handling #49
Conversation
|
Hey @2903Aishwarya, Thank you for raising the pr. Our team will review the changes soon |
| id = db.Column(db.Integer, primary_key=True) | ||
| name = db.Column(db.String(80), nullable=False) | ||
| client = MongoClient(MONGO_URI) | ||
| db = client[DB_NAME] |
There was a problem hiding this comment.
You have used name and main instead of name and main in:
app = Flask(_name_)
if _name_ == '_main_':
This will cause the app not to run as intended. Please fix to name and main.
| app = Flask(__name__) | ||
| app.config['SQLALCHEMY_DATABASE_URI'] = os.getenv('DATABASE_URL') | ||
| app.config['SQLALCHEMY_TRACK_MODIFICATIONS'] = False | ||
| # Config from environment variables |
There was a problem hiding this comment.
The new code uses MONGO_URI and DB_NAME env variables. Please update the README to document these and provide a sample .env file.
There was a problem hiding this comment.
This PR replaces the original Flask + SQLAlchemy + PostgreSQL stack with Flask + PyMongo + MongoDB. This is a significant architectural change! Please clarify if the intention is to migrate the entire sample from PostgreSQL to MongoDB or to create a new example. Consider documenting this decision in the README and migration guides if needed.
Key Features of This Template:
When to Use: