Skip to content

docs: handling sigterm in README #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2024
Merged

docs: handling sigterm in README #8

merged 1 commit into from
Mar 5, 2024

Conversation

PranshuSrivastava
Copy link
Contributor

@PranshuSrivastava PranshuSrivastava commented Mar 4, 2024

Issue that this pull request solves

Proposed changes

Need to add configuration to handle sigterm as Keploy sends sigterm signal to stop applications currently. We are sigterm = true because pytest by default handles only sigint signals but Keploy sends sigterm signals in order to stop application. Therefore in case of keploy, the coverage is not recorded properly. The debug mode is also set to false because the coverage file is not created when debug mode is set to tru.

Brief description of what is fixed or changed

Add the configuration for doing the same in .coveragerc

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have created new branch for this pull request
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
@re-Tick
Copy link

re-Tick commented Mar 4, 2024

Please mention why you need sigterm=true and debug mode false in the PR here. Else LGTM

@PranshuSrivastava PranshuSrivastava merged commit db6aa97 into main Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants