Skip to content

Conversation

@JiaT75
Copy link
Contributor

@JiaT75 JiaT75 commented Dec 8, 2021

No description provided.

@ecki
Copy link

ecki commented Mar 30, 2024

You might want to review those requests closely, the author is involved with the xz backdoor.

@ZLima12
Copy link

ZLima12 commented Mar 31, 2024

I only quickly skimmed over the changes here, but "adding color coding" is not all that is happening here. seatest_header_printer is also modified to accept the length of s as a parameter, rather than computing it manually in the function. This puts the responsibility on the caller to provide the right length. I don't see why this would be necessary, instead of just letting the function use strlen as it was.

Copy link

@johnzhou721 johnzhou721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A PR should only do one thing. The refactor of seatest_header_printer adding s_len is unnessacary and only serves to give you suspicions of malice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants