remove: use params helper like the other functions #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1cfbb96 to
e1b4ceb
Compare
Signed-off-by: William Casarin <jb55@jb55.com>
mdartic
reviewed
Mar 30, 2022
| @@ -99,8 +102,8 @@ S3BlobStore.prototype.createWriteStream = function (opts, s3opts, done) { | |||
| * @param {function(Error)} done callback | |||
| */ | |||
| S3BlobStore.prototype.remove = function (opts, done) { | |||
| var key = typeof opts === 'string' ? opts : opts.key; | |||
| this.s3.deleteObject({ Bucket: this.bucket, Key: key }, done); | |||
| const params = this.baseParams(opts) | |||
There was a problem hiding this comment.
I think you need to keep the typeof opts === 'string' test ?
Or test it in the baseParams function ?
As it is mentionned in https://github.com/maxogden/abstract-blob-store#storeremoveopts-cb,
the remove methods accept either a string (and that's the key) or an object.
Comment on lines
+61
to
+62
| const filename = opts.name || opts.filename || params.Key; | ||
| let contentType = opts.contentType || mime.lookup(filename) |
There was a problem hiding this comment.
I think filename is already present in params.Key,
as in baseParams function, you assign to params.Key either opts.name, opts.filename or opts.key.
Suggested change
| const filename = opts.name || opts.filename || params.Key; | |
| let contentType = opts.contentType || mime.lookup(filename) | |
| const contentType = opts.contentType || mime.lookup(params.Key) |
Also, as contentType is defined once, I think const is better than let ?
|
@jb55 do you want to merge this PR ? or was it just to show how to implement the feature ? |
|
On Mon, Apr 25, 2022 at 12:49:27AM -0700, Mathieu DARTIGUES wrote:
***@***.*** do you want to merge this PR ? or was it just to show how to implement the feature ?
I was hoping those who wanted this feature could test it (via npm link
or something) and ACK before I merge. we don't really have a good test
suite yet. I haven't heard anything back.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternative to #26
Signed-off-by: William Casarin jb55@jb55.com