Ensure default IP set in preference update script #11330
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes failing database transaction inserts in the legacy preference updater script by ensuring a default IP address is set. The issue occurred when web.ctx.site.save() calls failed due to missing IP addresses required for transaction table inserts.
- Added default IP address initialization to prevent transaction table insert failures
- Applied the same pattern used in
update_stale_ocaid_references.pyfor consistency
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #11310
Fixes failing
web.ctx.site.save()calls in legacy preference updater script by setting a default IP address. When no IP address is set, inserts into thetransactiontable fail.Now, when the script is being initialized,
127.0.0.1is set by default. A similar thing was done inupdate_stale_ocaid_references.py, here.Technical
Testing
Screenshot
Stakeholders