Fix/tweak some solr docker parameters #11319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes Solr Docker configuration across different environments (dev, staging, production) by adding environment labels and adjusting auto-commit timings for better development experience.
- Adds environment labels (
dev,stage,prod,test) to Solr admin dashboard for easier instance identification - Reduces auto soft commit time from 60s to 1s in local development environment for faster feedback
- Standardizes SOLR_HEAP configuration between staging and production environments
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| scripts/solr_builder/compose.yaml | Adds environment labels and adjusts commit timings for test and staging Solr instances |
| compose.yaml | Adds comprehensive documentation and environment label for base Solr configuration |
| compose.production.yaml | Adds standardized SOLR_OPTS configuration with environment label for production |
| compose.override.yaml | Overrides auto soft commit time to 1s for faster local development feedback |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While monitoring the new staging solr's performance noticed some of its settings were out-of-sync. Sync'd them + tweaks some of the other settings.
environmentflag, which adds a little coloured label to the admin dashboard, to reduce the likelihood of accidentallyTechnical
Testing
Screenshot
The label in the solr admin dashboard:
Stakeholders