Only update rpd value if patron requested access via Open Library
#11289
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR prevents updating the rpd (print disability request) status to "fulfilled" for patrons who didn't request special access through Open Library, addressing a data inconsistency where over 1,000 patrons had fulfilled status without having made a request.
- Adds a condition to check for the presence of
pda(print disability authority) before updatingrpdstatus - Ensures only patrons who actually requested access via Open Library get their status updated to fulfilled
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #10899
Background Information
Our
/admin/pdstats tell us that ~10 patrons have had their special access requests fulfilled (meaning theirrpdpreference has a value of2). However, there are over 1,000 patrons who have anrpd: 2, but nopdaauthority in the store.Why is this happening?
Whenever any patron logs in, we check the
xauthnresponse to see if they have special access. If they do, we update theirrpdstatus to fulfilled. This is done even if the patron did not request special access via Open Library. Such patrons can be identified by having a fulfilledrpdvalue, but nopdavalue in their preferences (this stores the patron's chosen print disability qualifying authority).How does this branch help?
This branch will prevent an
rpdvalue from being saved to a patron's preference object if they do not already have apdavalue.Technical
Testing
Screenshot
Stakeholders