Carousel safe mode #11287
Merged
Carousel safe mode #11287
+29
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements a "safe mode" feature for carousel templates to filter out books with potentially objectionable covers by adding a new safe_mode parameter that defaults to True across all carousel-related functions and templates.
- Adds
safe_modeparameter withTruedefault to all carousel templates and functions - Modifies query generation to exclude content with warning tags when safe mode is enabled
- Updates both Solr and advancedsearch.php query logic to filter objectionable content
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| openlibrary/templates/home/custom_ia_carousel.html | Adds safe_mode parameter and passes it to URL composition and carousel generation |
| openlibrary/plugins/openlibrary/partials.py | Enables safe_mode by default in browse query functionality |
| openlibrary/plugins/openlibrary/home.py | Adds safe_mode parameter to carousel book retrieval functions |
| openlibrary/macros/RawQueryCarousel.html | Implements query modification to exclude content warning covers when safe_mode is true |
| openlibrary/macros/QueryCarousel.html | Adds safe_mode parameter and passes it through to RawQueryCarousel |
| openlibrary/macros/ListCarousel.html | Adds safe_mode parameter and forwards it to QueryCarousel |
| openlibrary/core/lending.py | Implements safe_mode logic in URL composition to exclude no-preview collections |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11256
Adds new
safe_modekeyword parameter to all query carousel templates. Ifsafe_modeis true, the query that is used to populate the carousel is updated to avoid fetching items with potentially objectionable covers.safe_modeis true-subject:"content_warning:cover"is appended to the queryadvancedsearch.phpAND !collection:(no-preview)is appended to the queryTechnical
Testing
Screenshot
Stakeholders