Add click listener to remove identifier button #11283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a click event handler to the remove identifier button in the IdentifiersInput Vue component to enable actual removal functionality on edit pages.
- Adds a click listener that calls
removeIdentifier(name, idx)when the remove button is clicked
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@jimchamp and I tested on his local environment with the following cases:
|
|
Will test on testing.openlibrary.org and confirm with @seabelis before doing a deploy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #11208
Adds click listener to remove identifier buttons on edit pages.
Technical
Testing
Screenshot
Stakeholders