Remove unnecessary condition for price fetching #11266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change was made during a time when network security was blocking affiliate server requests.
There was a problem hiding this comment.
Pull Request Overview
Removes an unnecessary if False condition that was preventing price fetching from affiliate servers. This change re-enables price fetching functionality that was temporarily disabled due to network security issues.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
scottbarnes
approved these changes
Sep 12, 2025
There was a problem hiding this comment.
Looks good to me re prices.
I am unsure if it's anticipated this will (often) add covers if the covers are (1) missing and (2) on Amazon, because the records will have likely already been imported, so they won't get queued for import as ia_id: 'amazon:<whatever>' will already be in import_item. I am eager to be mistaken about this though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was made during a time when network security was blocking affiliate server requests.
Closes #11240 by removing unnecessary
if FalseTechnical
Testing
Screenshot
Stakeholders