read Library of Congress author name authority control from MARC #11262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements reading Library of Congress Name Authority File (LC NAF) control numbers from MARC records. It extracts authority control identifiers from subfield 0 in author fields and stores them as remote IDs to enable better author matching and deduplication.
- Adds parsing of LC NAF identifiers from MARC subfield 0
- Updates author records to include remote_ids field with lc_naf values
- Includes comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| openlibrary/catalog/marc/parse.py | Adds regex pattern and parsing logic to extract LC NAF IDs from author fields |
| openlibrary/catalog/marc/tests/test_parse.py | Adds test case to verify LC NAF ID extraction functionality |
| openlibrary/catalog/marc/tests/test_data/bin_expect/880_arabic_french_many_linkages.json | Updates expected test output to include remote_ids for authors |
| openlibrary/catalog/marc/tests/test_data/bin_expect/880_Nihon_no_chasho.json | Updates expected test output to include remote_ids for authors |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7724
Closes #
Technical
Testing
Screenshot
Stakeholders