Fix bot monitoring 'other' category #11257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a0685fd to
66bfa0e
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the bot monitoring system's categorization of 'other' bot traffic by correcting the filtering logic used to count different types of bot traffic.
- Replaces
obfi_top_bots -vwithobfi_grep_bots -vin the OTHER_BOTS_COUNT calculation - Adds
obfi_grep_bots -vfiltering to the NON_BOT_TRAFFIC_COUNT calculation - Updates test expectations to reflect the corrected counting logic
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/monitoring/utils.sh | Updates bot traffic filtering logic to use consistent grep function |
| scripts/monitoring/tests/test_utils_sh.py | Updates test expectations and adds FIXME comment about double counting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Confirmed the graphs now show the correct values on grafana. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Technical
Testing
Screenshot
Stakeholders