Make identifiers input mobile friendly #11244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11244 +/- ##
==========================================
+ Coverage 17.14% 17.80% +0.66%
==========================================
Files 91 93 +2
Lines 4981 5110 +129
Branches 867 890 +23
==========================================
+ Hits 854 910 +56
- Misses 3588 3650 +62
- Partials 539 550 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
25dcd54 to
52ee383
Compare
cdrini
approved these changes
Sep 26, 2025
There was a problem hiding this comment.
Nice lgtm @Lasseignejk ! One small bug with the popular identifiers appearing twice ; I imagine a rebase bug, fixed that. Also noticed the existing code duplicated the template for the value if housing a list of values, so DRY'd that up.
Tested:
- Adding/removing identifiers on book and saving
- Adding/removing identifiers on author
- Cannot add IA if not authorized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10620
Fixes an issue on mobile screens where the ID Numbers section's table breaks and causes a long horizontal scroll.
Technical
<table>,<th>, and<tr>elements to<div>s to enable more flexible styling using CSS grid.roletags to make more accessible for screen readers. Testing a screen reader on Chrome confirmed that when entering the table, it is able to identify the number of rows and columns, as well as which cell the patron is currently in.Testing
Select a book and press the 'Edit' button, then scroll down to the ID Numbers section. Opening up the Dev Tools in Chrome and selecting a mobile layout will show the updated table.
Screenshot
Stakeholders
@cdrini