set headers for wikidata get request #11198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #11199
@mekarpeles mentioned we were getting 403 nonstop from wikidata endpoint.
I recently noticed that we were often not loading data reliably.
Turns out it's because they have a user agent policy that is being enforced actively now here.
To test this I run the following code locally:
As we can see, with no headers we 403. But when you set headers it's 200.
If we were being blocked by wikidata for too many requests it would be a 429 (as I see locally when I use
hey
to make many requests)Technical
Testing
Screenshot
Stakeholders