Update solr to latest version, 9.9.0 #11188
Conversation
In 9.8, they deprecated the <lib> option from solrconfig.xml for security in favour of explicitly recognized modules via eg SOLR_MODULES environment variable. See https://solr.apache.org/guide/solr/latest/upgrade-notes/major-changes-in-solr-9.html#solr-9-8
There was a problem hiding this comment.
Pull Request Overview
Updates Apache Solr from version 9.5.0 to 9.9.0 to address security improvements introduced in Solr 9.8, which deprecated the <lib> configuration option in favor of explicit module declaration through environment variables.
- Upgraded Solr image version across all compose files
- Replaced deprecated
<lib>directives withSOLR_MODULESenvironment variable - Temporarily disabled Solr service in production compose to prevent unintended deployment
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/solr_builder/compose.yaml | Updated Solr image version and added SOLR_MODULES environment variable |
| conf/solr/conf/solrconfig.xml | Commented out deprecated <lib> directives for analysis-extras module |
| compose.yaml | Updated Solr image version and added SOLR_MODULES environment variable |
| compose.production.yaml | Disabled Solr service with "ol-never" profile to prevent production deployment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| solr: | ||
| profiles: ["ol-solr0"] | ||
| # Disabled while we're updating our version of solr, otherwise it'll pull down the new image! |
There was a problem hiding this comment.
The comment suggests this is a temporary change, but there's no indication of when or how this will be reverted. Consider adding a TODO comment with specific conditions for re-enabling the service or create a follow-up issue to track this.
| # Disabled while we're updating our version of solr, otherwise it'll pull down the new image! | |
| # Disabled while we're updating our version of solr, otherwise it'll pull down the new image! | |
| # TODO: Re-enable this service after the Solr version upgrade is complete and the new image is verified to work in production. |
Copilot uses AI. Check for mistakes.
Closes #11168
Technical
<lib>option from solrconfig.xml for security in favour of explicitly recognized modules via egSOLR_MODULESenvironment variable. See https://solr.apache.org/guide/solr/latest/upgrade-notes/major-changes-in-solr-9.html#solr-9-8solrservice out by tagging it with the profileol-never.Testing
Locally seems to work as per usual
Screenshot
Stakeholders