Add ebook_provider field to solr #11180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds an ebook_provider field to Solr indexing to track which providers offer ebooks for a given work or edition. The change supports storing and querying multiple provider names (e.g., "ia", "overdrive") alongside existing ebook access information.
- Adds
ebook_providerfield to Solr schema and document types - Updates edition and work updaters to collect provider names from available book providers
- Includes the new field in work search scheme for query support
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| openlibrary/solr/updater/work.py | Adds ebook_provider property that aggregates provider names from all editions |
| openlibrary/solr/updater/edition.py | Updates to use multiple providers and adds ebook_provider property to build method |
| openlibrary/solr/solr_types.py | Adds ebook_provider field to SolrDocument type definition |
| openlibrary/plugins/worksearch/schemes/works.py | Includes ebook_provider in work search fields |
| openlibrary/book_providers.py | Adds provider_name property and updates provider lookup function |
| conf/solr/conf/managed-schema.xml | Defines ebook_provider as a multi-valued string field in Solr schema |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11144
This will allow us to find direct book provided books with
ebook_provider:direct(vs egebook_provider:iaorbook_provider:standard_ebooks, etc)Technical
Testing
Screenshot
Stakeholders