Skip to content

Improving Private button design #11162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2025
Merged

Improving Private button design #11162

merged 1 commit into from
Aug 22, 2025

Conversation

@krishnaGauss
Copy link
Contributor

Closes #11139

This PR aims to improve the design of Private button.

Earlier Private button was not able to convey the meaning of what was private?.

Technical

  • Changed Private to 🔒︎ Follow to help convey the message behind the unclickable button.
  • Added hover tooltip for desktop readers with a message.
  • Added toast for mobile users conveying the same message.

Testing

  • One can click on any books and scroll down to Lists
  • For patrons who have made their reading logs private, one would see a 🔒︎ Follow button.
  • On clicking this follow button one would notice a toast message saying "This patron has not enabled following".

Screenshot

Screenshot (119) Screenshot 2025-08-17 140720

Stakeholders

@mekarpeles @ragipidavid

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.80%. Comparing base (e027195) to head (bb30778).
⚠️ Report is 438 commits behind head on master.

Files with missing lines Patch % Lines
...nlibrary/plugins/openlibrary/js/book-page-lists.js 0.00% 6 Missing and 1 partial ⚠️
...enlibrary/plugins/openlibrary/js/private-button.js 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #11162      +/-   ##
==========================================
+ Coverage   17.14%   17.80%   +0.66%     
==========================================
  Files          91       93       +2     
  Lines        4981     5110     +129     
  Branches      867      890      +23     
==========================================
+ Hits          854      910      +56     
- Misses       3588     3650      +62     
- Partials      539      550      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Aug 18, 2025
@mekarpeles mekarpeles merged commit f574e2e into internetarchive:master Aug 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mekarpeles mekarpeles

Labels

Needs: Response Issues which require feedback from lead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improving the Private Button in Lists Card

3 participants

@krishnaGauss @codecov-commenter @mekarpeles