Add ISFDB (Internet Speculative Fiction Database) identifiers support #11146
Conversation
|
@mekarpeles 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: mekarpeles <978325+mekarpeles@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive support for ISFDB (Internet Speculative Fiction Database) identifiers across all entity types in Open Library, enabling users to link authors, works, and editions to this specialized database for science fiction and fantasy materials.
- Adds new ISFDB identifier configuration for authors and works
- Updates existing ISFDB configuration for editions to use HTTPS
- Maintains alphabetical ordering and follows existing configuration patterns
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| openlibrary/plugins/openlibrary/config/author/identifiers.yml | Adds ISFDB support for authors with appropriate URL pattern and metadata |
| openlibrary/plugins/openlibrary/config/edition/identifiers.yml | Updates existing ISFDB configuration to use HTTPS instead of HTTP |
| openlibrary/plugins/openlibrary/config/work/identifiers.yml | Adds ISFDB support for works/titles with URL pattern for title lookup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| - label: Internet Speculative Fiction Database | ||
| name: isfdb | ||
| notes: Should be a number | ||
| url: https://www.isfdb.org/cgi-bin/title.cgi?@@@ |
There was a problem hiding this comment.
The URL pattern uses '@@@' as placeholder while other identifiers in the codebase use '{ID}' format as mentioned in the PR description. Consider using consistent placeholder format across all identifier configurations.
| - label: Internet Speculative Fiction Database | ||
| name: isfdb | ||
| notes: Should be a number | ||
| url: https://www.isfdb.org/cgi-bin/ea.cgi?@@@ |
There was a problem hiding this comment.
The URL pattern uses '@@@' as placeholder while the PR description mentions '{ID}' format. Consider using consistent placeholder format across all identifier configurations.
This PR adds comprehensive support for ISFDB (Internet Speculative Fiction Database) identifiers across all entity types in Open Library.
Changes Made
Added ISFDB Support for Authors
https://www.isfdb.org/cgi-bin/ea.cgi?{ID}Added ISFDB Support for Works
https://www.isfdb.org/cgi-bin/title.cgi?{ID}Updated ISFDB Support for Editions
https://www.isfdb.org/cgi-bin/pl.cgi?{ID}About ISFDB
The Internet Speculative Fiction Database (ISFDB) is a comprehensive database of science fiction and fantasy authors and works. It serves as an invaluable resource for both users and librarians to:
Implementation Details
The implementation follows Open Library's existing identifier system by updating the YAML configuration files:
openlibrary/plugins/openlibrary/config/author/identifiers.ymlopenlibrary/plugins/openlibrary/config/edition/identifiers.ymlopenlibrary/plugins/openlibrary/config/work/identifiers.ymlEach identifier includes appropriate metadata:
@@@placeholder for the IDAll changes maintain alphabetical ordering within the configuration files and follow existing conventions.
Fixes #11136.